Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Maven/Nightly build fix - bundle names change #1183

Merged

Conversation

rfelcman
Copy link
Contributor

@rfelcman rfelcman commented Jun 10, 2021

This is fix for issue related with eclipselink-plugins.zip bundle.
Main purpose of this fix is to keep names of the orc.eclipse.persistence artifacts packed in eclipselink-plugins.zip bundle consistent with older versions of the EclipseLink.
EclipseLink artifacts in eclipselink-plugins-*.zip are named in the same way as in 2.6, 2.7 bundles
e.g. org.eclipse.persistence.core_2.7.9.v20210604-2c549e2208.jar x org.eclipse.persistence.core_3.0.2.v20210610-1fda5b4d4e.jar
MANIFEST.MF content is changed too.
Bundle-Version contains major.minor.micro.version.vYYYYMMDDHHmm e.g. Bundle-Version: 3.0.2.v202106101448
plus new additional properties e.g.

Implementation-Version: 3.0.2-SNAPSHOT
Implementation-SCM-Revision: 1fda5b4d4e
Implementation-SCM-Branch: 3.0

Some note about bundles at Eclipse.org lifecycle.
These bundles available at
https://www.eclipse.org/eclipselink/downloads/nightly.php
https://www.eclipse.org/eclipselink/downloads/milestones.php
https://www.eclipse.org/eclipselink/downloads/
are build during a nightly build.
During promotion/release process are generated just Maven artifacts published at
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/eclipselink/2.7.9/
and later
in the Maven Central.
Bundles at Eclipse.org are just copied from Nightly to Milestones (e.g. RC1, MP1, ...) and Download (Final).
This is reason why timestamp stored in bundles at Eclipse.org is usually older, than timestamp in artifacts stored in Maven Central.

How to verify/test it without Jenkins environment (nightly build job):

populateTestResultsHTML.tar.gz

Signed-off-by: Radek Felcman radek.felcman@oracle.com

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
@rfelcman rfelcman requested review from lukasj and dazey3 June 10, 2021 07:52
Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
@rfelcman
Copy link
Contributor Author

rfelcman commented Jun 14, 2021

UPDATE: To easily identify bundles if there are multiple nightly builds per day. Bundle name/qualifier contains time part e.g.
eclipselink-plugins-3.0.2.v202106141114-8733f1d7a0.zip and artifacts inside e.g. org.eclipse.persistence.core_3.0.2.v202106141057-8733f1d7a0.jar.

@rfelcman rfelcman changed the title Maven/Nightly build fix - bundle names change [3.0] Maven/Nightly build fix - bundle names change Jul 7, 2021
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 2a0820a into eclipse-ee4j:3.0 Jul 12, 2021
@rfelcman rfelcman deleted the maven_build_nightly_bundles_fix_3.0 branch September 23, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants