Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Maven build - JPARS module Manifest generation - backport from master #1157

Merged
merged 2 commits into from May 26, 2021

Conversation

rfelcman
Copy link
Contributor

Behind this fix is some issue with org.apache.felix:maven-bundle-plugin. This plugin inserts into generated MANIFEST.MF file Maven project properties, but only properties in capital characters. Maven properties in lowercase characters are ignored and not included into manifest. I tried to upgrade into latest version of org.apache.felix:maven-bundle-plugin:5.1.2, but without any change.

Signed-off-by: Radek Felcman radek.felcman@oracle.com

Behind this fix is some issue with org.apache.felix:maven-bundle-plugin. This plugin inserts into generated MANIFEST.MF file Maven project properties, but only properties in capital characters. Maven properties in lowercase characters are ignored and not included into manifest. I tried to upgrade into latest version of org.apache.felix:maven-bundle-plugin:5.1.2, but without any change.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
(cherry picked from commit 4708ec2)
Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 73bad2f into eclipse-ee4j:3.0 May 26, 2021
@rfelcman rfelcman deleted the maven_build_jpars_manifest_3.0 branch May 26, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants