Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proper JPMS descriptor, upgrade build plugins #72

Merged
merged 2 commits into from Feb 7, 2020

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Feb 7, 2020

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj requested a review from m0mus February 7, 2020 15:29
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj
Copy link
Contributor Author

lukasj commented Feb 7, 2020

fixes #62

@m0mus m0mus merged commit b623aa8 into jakartaee:master Feb 7, 2020
@lukasj lukasj deleted the mi branch February 10, 2020 09:00
@lukasj lukasj mentioned this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants