Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Deprecated to ManagedBean #105

Merged
merged 3 commits into from Jun 14, 2022
Merged

Conversation

starksm64
Copy link
Contributor

Signed-off-by: Scott M Stark starksm64@gmail.com

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a reason for deprecation into javadoc

@Emily-Jiang
Copy link

It would be good to add a reason for deprecation into javadoc

Not sure about this though because in the next release this file will be

It would be good to add a reason for deprecation into javadoc

I suggest to add a comment to say what to be used instead. We could say something like this to aid the migration:
This annotation is marked for removal. A CDI bean should be used instead.

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Contributor Author

Updated with javadoc comment.

@starksm64 starksm64 requested a review from lukasj June 7, 2022 18:13
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerbroker
Copy link

people what are you doing? - Jakarta Managed Beans 2.0, 2.1.2. Naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants