Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize the leftOperand as an @id #4185

Merged
merged 2 commits into from
May 16, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented May 15, 2024

What this PR changes/adds

serialize the leftOperand of a constraint as an @id

The breaking change only affects management API, since at protocol level EDC in input can handle both @value and @id as expanded form

Linked Issue(s)

Closes #4179

@wolf4ood wolf4ood self-assigned this May 15, 2024
@wolf4ood wolf4ood added bug Something isn't working breaking-change Will require manual intervention for version update labels May 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (7f20ba5) to head (b11b852).
Report is 255 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4185      +/-   ##
==========================================
+ Coverage   71.74%   75.04%   +3.29%     
==========================================
  Files         919     1012      +93     
  Lines       18457    20548    +2091     
  Branches     1037     1160     +123     
==========================================
+ Hits        13242    15420    +2178     
+ Misses       4756     4620     -136     
- Partials      459      508      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood marked this pull request as ready for review May 15, 2024 16:28
@wolf4ood wolf4ood merged commit ef7b502 into eclipse-edc:main May 16, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No persistence of nested odrl:leftOperand.@id property in /v2/policydefinitions API
3 participants