Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support raw devfile urls without yaml extension #683

Merged
merged 5 commits into from May 15, 2024
Merged

Support raw devfile urls without yaml extension #683

merged 5 commits into from May 15, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented May 9, 2024 •
edited

What does this PR do?

On handling raw devfile urls, request content by the url, and check if the content is a devfile. If yes treat the url as a raw devfile url.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22937

How to test this PR?

  1. Deploy che with the PR image: quay.io/eclipse/che-server:pr-683
  2. Start a workspace from a raw devfile url without yaml extension, e.g. https://raw.githubusercontent.com/vinokurig/test/master/parent

See: workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Support raw devfile urls without yaml extension
a509dd5 
Signed-off-by: ivinokur <ivinokur@redhat.com>
@vinokurig @tolusha
Update wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/ap…
ec3ee70 
…i/factory/server/RawDevfileUrlFactoryParameterResolver.java

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

/retest

2 similar comments
@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

/retest

tolusha
tolusha approved these changes May 13, 2024
View reviewed changes
.../src/main/java/org/eclipse/che/api/factory/server/RawDevfileUrlFactoryParameterResolver.java Outdated
devfileParser.parseYaml(fetch);
return true;
} catch (IOException | DevfileFormatException e) {
return !e.getMessage().startsWith("Cannot construct instance of");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds unclear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked to parsing raw yaml

@openshift-ci openshift-ci bot added the lgtm label May 13, 2024
@openshift-ci openshift-ci bot removed the lgtm label May 13, 2024
@vinokurig
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2024

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-gitlab-with-oauth-setup-flow 974595e link true /test v14-gitlab-with-oauth-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ibuziuk ibuziuk requested a review from artaleks9 May 14, 2024 10:59
@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
@artaleks9
Copy link
Contributor

The gitlab-with-oauth-setup-flow is failed.
Maybe, it's related to UI locator change
I need to investigate it.

@artaleks9
Copy link
Contributor

artaleks9 commented May 14, 2024 •
edited

@vinokurig the gitlab-with-oauth-setup-flow is fail due to the known issue -> eclipse-che/che#22953
The Views and More Actions menu is not available (see the screenshot)

@RomanNikitenko said this problem was resolved in the next 4 days ago, but, it seems, this che-sever image is not included the fix.
@vinokurig Do we have an opportunity update the PR image, to rerun the gitlab-with-oauth-setup-flow test and verify it?

Anyway I've checked the functionality related to the PR and OAuth - works properly.

che-pr-683

@vinokurig
Copy link
Contributor Author

@artaleks9

Do we have an opportunity update the PR image, to rerun the gitlab-with-oauth-setup-flow test and verify it?

The PR image is already up to date with the main branch.

@vinokurig
Copy link
Contributor Author

@artaleks9 If the failure is a known issue, can we go with the current changes?

@RomanNikitenko
Copy link
Member

I see on the screenshot that editor version is pretty old - it was built 2 weeks ago.
I think editor image should be updated for testing.

@artaleks9
Copy link
Contributor

| @artaleks9 If the failure is a known issue, can we go with the current changes?
I think, yes

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 88cbaeb into main May 15, 2024
27 of 28 checks passed
@vinokurig vinokurig deleted the che-22937 branch May 15, 2024 07:13
@devstudio-release
Copy link

Build 3.15 :: server_3.x/339: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6816: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6766: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: push-latest-container-to-quay_3.x/4649: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6766: SUCCESS

server : 3.x :: Build 61397668 : quay.io/devspaces/server-rhel8:3.15-1
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4649 triggered

@devstudio-release
Copy link

Build 3.15 :: server_3.x/339: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6816 triggered

@devstudio-release
Copy link

Build 3.15 :: update-digests_3.x/6641: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3012: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6817: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6767: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6767: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61398909 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@tolusha tolusha tolusha approved these changes

@artaleks9 artaleks9 artaleks9 approved these changes

@SDawley SDawley Awaiting requested review from SDawley SDawley is a code owner

Assignees

@ibuziuk ibuziuk

@tolusha tolusha

@artaleks9 artaleks9

Labels
lgtm
Projects
None yet
Milestone
No milestone
6 participants
@vinokurig @artaleks9 @RomanNikitenko @devstudio-release @ibuziuk @tolusha