Same workspace actions menu #1108
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
Click here to review and test in web IDE: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
==========================================
+ Coverage 89.07% 89.29% +0.21%
==========================================
Files 406 407 +1
Lines 41698 41469 -229
Branches 2792 2761 -31
==========================================
- Hits 37143 37030 -113
+ Misses 4528 4413 -115
+ Partials 27 26 -1 ☔ View full report in Codecov by Sentry. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
packages/dashboard-frontend/src/contexts/WorkspaceActions/DeleteButton/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…teButton/__tests__/index.spec.tsx Co-authored-by: Oleksii Orel <oorel@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1108 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1108", name: che-dashboard}]}}]" |
|
Build 3.14 :: dashboard_3.x/489: Console, Changes, Git Data |
|
Build 3.14 :: sync-to-downstream_3.x/6768: Console, Changes, Git Data |
|
Build 3.14 :: push-latest-container-to-quay_3.x/4623: Console, Changes, Git Data |
|
Build 3.14 :: get-sources-rhpkg-container-build_3.x/6721: dashboard : 3.x :: Build 61187015 : quay.io/devspaces/dashboard-rhel8:3.14-9 |
|
Build 3.14 :: update-digests_3.x/6570: Console, Changes, Git Data |
|
Build 3.14 :: dashboard_3.x/489: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6768 triggered |
|
Build 3.14 :: operator-bundle_3.x/2986: Console, Changes, Git Data |
|
Build 3.14 :: sync-to-downstream_3.x/6769: Console, Changes, Git Data |
|
Build 3.14 :: push-latest-container-to-quay_3.x/4624: Console, Changes, Git Data |
|
Build 3.14 :: copyIIBsToQuay/2642: Console, Changes, Git Data |
|
Build 3.14 :: sync-to-downstream_3.x/6769: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6722 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.14 :: operator-bundle_3.x/2986: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6769 triggered |
|
Build 3.14 :: update-digests_3.x/6570: Detected new images: rebuild operator-bundle |
|
Build 3.14 :: dsc_3.x/1915: Console, Changes, Git Data |
|
Build 3.14 :: dsc_3.x/1915: 3.14.0-CI |
What does this PR do?
The workspace actions menu closes as expected.
Demo
Screen.Recording.2024-05-08.at.12.25.30.mov
All the workspace action menus look the same.
Demo
Recent workspaces in sidebar
Workspaces list page
Workspace details page
What issues does this PR fix or reference?
fixes eclipse-che/che#22931
fixes https://issues.redhat.com/browse/CRW-6269