Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Node / ECU via rename_ecu should clear out any existing transmitter and receiver #760

Open
ChristianSteffens opened this issue Jan 10, 2024 · 1 comment
Assignees
Labels

Comments

@ChristianSteffens
Copy link

Hi,

I noticed a problem (bug?) in the db.rename_ecu method and specifically the usage of the frame.update_receiver() method.

The method should cover a rename attempt of an existing ECU throughout the complete database:

  • Any existing usage of an ECU with the old name is removed from frames transmitter and signals receiver list - works as expected.
  • Then it calls frame.update_receiver() to make sure the frame's signal receiver list is propagated to the frame itself.

But here a catch as the frame's receiver list is not cleared / emptied before (!) updating the list, so any previous occurance of any ECU (e.g. the ECU with the old name) is still carried over.

So the correct method should empty the receiver array of the frame before updating it via the signals receiver list.

@ebroecker ebroecker self-assigned this Jan 12, 2024
@ebroecker ebroecker added the bug label Jan 12, 2024
@ChristianSteffens
Copy link
Author

Any interest in fixing this - if not should I raise a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants