Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PercClassLoader misspelled in pom.xml #76

Closed
jest opened this issue Apr 30, 2020 · 0 comments · Fixed by #80
Closed

PercClassLoader misspelled in pom.xml #76

jest opened this issue Apr 30, 2020 · 0 comments · Fixed by #80

Comments

@jest
Copy link

jest commented Apr 30, 2020

The package name COM.newmonics.PercClassLoader, used as part of classes loaded in PercSerializationInstantiator is misspelled in pom.xml (L vs l):

COM.newmonics.PercClassloader;resolution:=optional,

This causes the Objenesis bundle to not resolve in OSGi context (i.e. the bundle cannot be resolved by Bnd in bndrun files because COM.newmonics.PercClassLoader is not marked as optional, only misspelled COM.newmonics.PercClassloader).

Of course it might be the other way around, and PercSerializationInstantiator needs fixing. :)

BTW, there are more Class.forName() usage in the code, which should be marked as optional (e.g. android.os). I work with OSGi, so I can assist if you need help.

@henri-tremblay henri-tremblay added this to the 3.2 milestone Sep 24, 2020
Tazminia added a commit to Tazminia/objenesis that referenced this issue Oct 1, 2020
@Tazminia Tazminia mentioned this issue Oct 1, 2020
henri-tremblay pushed a commit that referenced this issue Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants