@Mock default name is not used in failure messages

[sloescape]

Although @mock usefully generates a default name for a mock using the field name, this name is not used when reporting failures, for example in verify failures. The issue is in Invocation.getMockAndMethodName which does not use the generated name for the mock if it does not look like a java identifier, which the generated name does not. As a result I believe the value of the @mock facility is reduced because it requires the manual addition of a 'name' attribute to differentiate mocks of the same type which in almost all cases will be the same as the field name.

[henri-tremblay]

But a field name should be a Java identifier no?

[sloescape]

It is the generated mock name that does not pass the check for a valid java identifier. Invocation.getMockAndMethodName has 'String mockName = mock.toString();' which gives a default mockName of "EasyMock for ...." which is not a valid java identifier as it include space characters.

[henri-tremblay]

Can you give me a quick test case for that? Because I remember changing something in that realm. So maybe it's fixed now.

[sloescape]

A simple test case with two tests. In both cases the error refers to the failing mock as 'Runnable' instead of 'myRunner1' or 'myRunner2':

package test;

import org.easymock.EasyMockExtension;
import org.easymock.EasyMockSupport;
import org.easymock.Mock;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

@ExtendWith({EasyMockExtension.class})
public class MockTest extends EasyMockSupport {

@Mock
private Runnable myRunner1;

@Mock
private Runnable myRunner2;

@AfterEach
public void verify() {
    verifyAll();
}

@Test
public void testUnexpected() {
    replayAll();
    myRunner1.run();
}

@Test
public void testFailsVerify() {
    myRunner2.run();
    replayAll();
}

}