-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some utilities for comparison notebooks #283
Comments
As a scientist doing a comparison study using eWaterCycle, We could make
This would work for all paths that are specific to the comparison study but not generic enough for adding them to the main ewatercycle package. Can also be used for the |
As a writer of the comparison paper, Since the BMI interface makes it relatively easy to do calibration "outside" of the main model code using a wide variety of calibration routines, we don't want to add it to the ewatercycle package (yet). However, if we find that some functions can be generic enough and useful, we might still do that in a later stage. For now, let's make |
As a user of lisflood, Until we move lisvap to the |
For PCRGlob, there are a couple of functions that might be generalizable as well or could at least be refactored into utils:
|
For wflow the following candidates for refactoring:
|
cc @Peter9192 and @sverhoeven:
More path to ewatercycle system-related config file (grouped based on models):
Example usage would be:
MODEL_OUTPUT_BASE_DIR = ewatercycle.config.CFG["model_output_base_dir"]["marrmot-m01"]
Generic util functions that can be used by most of the models:
ewatercycle.config.CFG["output_dir"] / model_name_{time.strftime('%Y%m%d_%H%M%S')}"
Marrmot calibration module that can be used for three marrmot models:
lisflood specific that can be added to forcing module:
I didn't look at hype, pcrglob and wflow.
The text was updated successfully, but these errors were encountered: