Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept meta-tagged actions and send them over wss #91

Open
dzintars opened this issue Jul 28, 2020 · 2 comments
Open

Intercept meta-tagged actions and send them over wss #91

dzintars opened this issue Jul 28, 2020 · 2 comments
Assignees
Labels
idea Ideas and concepts
Projects

Comments

@dzintars
Copy link
Owner

In 4327900 commit i removed option to automatically intercept meta: { websocket: true} tagged actions.
I kinda liked and still like this approach as it requires just to tag relative actions, but at the same time it's somewhat limits the signature of the action signature which is sent to the server.
Also by implementing webSocketSend() action it opens doors for more fine grained control. Not sure is it good or not.. will see.
Other awkward point is that webSocketSend() expects explicit signature. But there are actions with type only, there could be an actions with type and payload as well. And probably there could be more variations.
Mby i need to implement like strict action kind policy. Like "event actions" which contains only the type field. And "command actions" which should contain type and payload fields. Not sure.

Will try to research this point. For now - it is as it is.

@dzintars dzintars self-assigned this Jul 28, 2020
@dzintars dzintars added the idea Ideas and concepts label Jul 28, 2020
@dzintars
Copy link
Owner Author

dzintars commented Jul 28, 2020

meta: { websocket: true} approach would allow to do something like this meta: { websocket: true, host: "wss://public.api.domain.com"}. I mean, it could be possible to specify to which host this action should go. But it has it's own downsides by cluttering the codebase with host addresses there and there.

@dzintars dzintars added this to Backlog in WebSockets Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Ideas and concepts
Projects
WebSockets
  
Backlog
Development

No branches or pull requests

1 participant