Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse negative numbers from envvar Fix #799 and Fix #585 #802

Merged
merged 1 commit into from Sep 5, 2022
Merged

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Sep 5, 2022

TOML reads signed integers as int on Python

num = -1

turns to

assert settings.num == -1
assert isinstance(settings.num, int)

On validators, when is_type_of=str is passed we need to bypass this conversion and force a str

@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit eb4fd80
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/63164a5322e45c0008e8b092
😎 Deploy Preview https://deploy-preview-802--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Test Results (Python 3.8)

366 tests  +2   366 ✔️ +2   29s ⏱️ -10s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit eb4fd80. ± Comparison against base commit d7824e5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Test Results (Python 3.10)

366 tests  +2   366 ✔️ +2   35s ⏱️ -1s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit eb4fd80. ± Comparison against base commit d7824e5.

♻️ This comment has been updated with latest results.

@rwbeauchemin
Copy link

Hello @rochacbruno, do you know when you're aiming to release the next version into pypi? We are hoping to utilize this fix.

@rochacbruno
Copy link
Member Author

@rwbeauchemin I am going on vacation for 2 weeks, I want to do more tests before releasing a minor version, maybe we add a 3.1.10 before the 3.2.0 with only the bug fixes.

However it will be in 2 weeks from now.

@rwbeauchemin
Copy link

Good to know, thanks @rochacbruno!

rochacbruno added a commit that referenced this pull request Sep 22, 2022
Shortlog of commits since last release:

    Amadou Crookes (1):
          envars.md typo fix (#786)

    Bruno Rocha (19):
          Release version 3.1.9
          Bump dev version to 3.1.10
          Update badges
          demo repo will be replaced by a video tutorial soon
          Fix CI
          New data key casing must adapt to existing key casing (#795)
          Add test and docs about includes (#796)
          Removed vendor_src folder (#798)
          Replacing rochacbruno/ with dynaconf/ (#800)
          Fix codecov (#801)
          Parse negative numbers from envvar Fix #799 and Fix #585 (#802)
          Fix get command with Django (#804)
          Add a functional test runner (#805)
          Test runner docs and styling (#806)
          Allow merge_unique on lists when merge_enabled=True (#810)
          Rebind current env when forced for Pytest Fix #728 (#809)
          AUTO_CAST can be enabled on instance (#811)
          Ensure pyminify is on release script
          Add missing tomllib to monify script

    Gaurav Talreja (1):
          Fix #807 Use client.auth.approle.login instead of client.auth_approle (#808)

    Jitendra Yejare (1):
          Fix #768 of kv property depreciation from client object (#769)

    Joren Retel (2):
          Feature/detect casting comb token from converters (#784)
          Adding documentation and example to makefile. (#791)

    João Gustavo A. Amorim (1):
          Add pyupgrade hook (#759)

    Kian-Meng Ang (1):
          Fix typos (#788)

    Lucas Limeira (1):
          Using filter_strategy in env_loader to fix #760 (#767)

    Nicholas Nadeau, Ph.D., P.Eng (1):
          fix: typo (#766)

    Oleksii Baranov (2):
          Bump codecov action version (#775)
          Fix cli init command for flask (#705) (#774)

    Pedro de Medeiros (1):
          documentation fixes (#771)

    The Gitter Badger (1):
          Add a Gitter chat badge to README.md (#776)

    Théo Melo (1):
          Fixing a typo on the readme file (#763)

    Vicente Marçal (1):
          docs(pt-br): Docs Translation to brazilian portugues. (#787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants