diff --git a/CHANGELOG.md b/CHANGELOG.md index d302331b009..3b05367b437 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ * [#8895](https://github.com/rubocop-hq/rubocop/pull/8895): Add new `Lint/EmptyBlock` cop. ([@fatkodima][]) * [#7549](https://github.com/rubocop-hq/rubocop/issues/7549): Add new `Style/ArgumentsForwarding` cop. ([@koic][]) +### Changes + +* [#8920](https://github.com/rubocop-hq/rubocop/pull/8920): Remove Capybara's `save_screenshot` from `Lint/Debugger`. ([@ybiquitous][]) + ## 1.0.0 (2020-10-21) ### New features diff --git a/lib/rubocop/cop/lint/debugger.rb b/lib/rubocop/cop/lint/debugger.rb index 4f48a06ff7b..d5aae9738c3 100644 --- a/lib/rubocop/cop/lint/debugger.rb +++ b/lib/rubocop/cop/lint/debugger.rb @@ -37,7 +37,7 @@ class Debugger < Base RESTRICT_ON_SEND = %i[ debugger byebug remote_byebug pry remote_pry pry_remote console rescue - save_and_open_page save_and_open_screenshot save_screenshot irb + save_and_open_page save_and_open_screenshot irb ].freeze def_node_matcher :kernel?, <<~PATTERN @@ -53,8 +53,7 @@ class Debugger < Base {:pry :remote_pry :pry_remote :console} ...) (send (const {nil? (cbase)} :Pry) :rescue ...) (send nil? {:save_and_open_page - :save_and_open_screenshot - :save_screenshot} ...)} + :save_and_open_screenshot} ...)} PATTERN def_node_matcher :binding_irb_call?, <<~PATTERN diff --git a/spec/rubocop/cop/lint/debugger_spec.rb b/spec/rubocop/cop/lint/debugger_spec.rb index 66bf92da4de..aeb375b2d8e 100644 --- a/spec/rubocop/cop/lint/debugger_spec.rb +++ b/spec/rubocop/cop/lint/debugger_spec.rb @@ -51,13 +51,6 @@ RUBY end - it 'reports an offense for save_screenshot' do - expect_offense(<<~RUBY) - save_screenshot - ^^^^^^^^^^^^^^^ Remove debugger entry point `save_screenshot`. - RUBY - end - context 'with an argument' do it 'reports an offense for save_and_open_page' do expect_offense(<<~RUBY) @@ -72,13 +65,6 @@ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Remove debugger entry point `save_and_open_screenshot foo`. RUBY end - - it 'reports an offense for save_screenshot' do - expect_offense(<<~RUBY) - save_screenshot foo - ^^^^^^^^^^^^^^^^^^^ Remove debugger entry point `save_screenshot foo`. - RUBY - end end end @@ -161,7 +147,7 @@ end %w[debugger byebug console pry remote_pry pry_remote irb save_and_open_page - save_and_open_screenshot save_screenshot remote_byebug].each do |src| + save_and_open_screenshot remote_byebug].each do |src| it "does not report an offense for a #{src} in comments" do expect_no_offenses("# #{src}") end