forked from rubocop/rubocop
/
ambiguous_operator_precedence_spec.rb
123 lines (106 loc) · 4.13 KB
/
ambiguous_operator_precedence_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::AmbiguousOperatorPrecedence, :config do
it 'does not register an offense when there is only one operator in the expression' do
expect_no_offenses(<<~RUBY)
a + b
RUBY
end
it 'does not register an offense when all operators in the expression have the same precedence' do
expect_no_offenses(<<~RUBY)
a + b + c
a * b / c % d
a && b && c
RUBY
end
it 'does not register an offense when expressions are wrapped in parentheses by precedence' do
expect_no_offenses(<<~RUBY)
a + (b * c)
(a ** b) + c
RUBY
end
it 'does not register an offense when expressions are wrapped in parentheses by reverse precedence' do
expect_no_offenses(<<~RUBY)
(a + b) * c
a ** (b + c)
RUBY
end
it 'does not register an offense when boolean expressions are wrapped in parens' do
expect_no_offenses(<<~RUBY)
(a && b) || c
a || (b & c)
RUBY
end
it 'registers an offense when an expression with mixed precedence has no parens' do
expect_offense(<<~RUBY)
a + b * c
^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
RUBY
expect_correction(<<~RUBY)
a + (b * c)
RUBY
end
it 'registers an offense when an expression with mixed boolean operators has no parens' do
expect_offense(<<~RUBY)
a && b || c
^^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
a || b && c
^^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
RUBY
expect_correction(<<~RUBY)
(a && b) || c
a || (b && c)
RUBY
end
it 'registers an offense for expressions containing booleans and operators' do
expect_offense(<<~RUBY)
a && b * c
^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
a * b && c
^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
RUBY
expect_correction(<<~RUBY)
a && (b * c)
(a * b) && c
RUBY
end
it 'registers an offense when the entire expression is wrapped in parentheses' do
expect_offense(<<~RUBY)
(a + b * c ** d)
^^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
^^^^^^^^^^ Wrap expressions with varying precedence with parentheses to avoid ambiguity.
RUBY
expect_correction(<<~RUBY)
(a + (b * (c ** d)))
RUBY
end
it 'corrects a super long expression in precedence order' do
expect_offense(<<~RUBY)
a ** b * c / d % e + f - g << h >> i & j | k ^ l && m || n
^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
RUBY
expect_correction(<<~RUBY)
(((((((a ** b) * c / d % e) + f - g) << h >> i) & j) | k ^ l) && m) || n
RUBY
end
it 'corrects a super long expression in reverse precedence order' do
expect_offense(<<~RUBY)
a || b && c | d ^ e & f << g >> h + i - j * k / l % n ** m
^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Wrap expressions [...]
RUBY
expect_correction(<<~RUBY)
a || (b && (c | d ^ (e & (f << g >> (h + i - (j * k / l % (n ** m)))))))
RUBY
end
end