forked from rubocop/rubocop
/
empty_method_spec.rb
348 lines (293 loc) · 8.51 KB
/
empty_method_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::EmptyMethod, :config do
context 'when configured with compact style' do
let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
context 'with an empty instance method definition' do
it 'registers an offense for empty method' do
expect_offense(<<~'RUBY')
def foo
^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def foo; end
RUBY
end
it 'registers an offense for method with arguments' do
expect_offense(<<~'RUBY')
def foo(bar, baz)
^^^^^^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def foo(bar, baz); end
RUBY
end
it 'registers an offense for method with arguments without parens' do
expect_offense(<<~'RUBY')
def foo bar, baz
^^^^^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def foo bar, baz; end
RUBY
end
it 'registers an offense for method with blank line' do
expect_offense(<<~'RUBY')
def foo
^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def foo; end
RUBY
end
it 'registers an offense for method with closing paren on following line' do
expect_offense(<<~RUBY)
def foo(arg
^^^^^^^^^^^ Put empty method definitions on a single line.
); end
RUBY
expect_correction(<<~RUBY)
def foo(arg); end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def foo; end')
end
end
context 'with a non-empty instance method definition' do
it 'allows multi line method' do
expect_no_offenses(<<~RUBY)
def foo
bar
end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def foo; bar; end')
end
it 'allows multi line method with comment' do
expect_no_offenses(<<~RUBY)
def foo
# bar
end
RUBY
end
end
context 'with an empty class method definition' do
it 'registers an offense for empty method' do
expect_offense(<<~'RUBY')
def self.foo
^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def self.foo; end
RUBY
end
it 'registers an offense for empty method with arguments' do
expect_offense(<<~'RUBY')
def self.foo(bar, baz)
^^^^^^^^^^^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def self.foo(bar, baz); end
RUBY
end
it 'registers an offense for method with blank line' do
expect_offense(<<~'RUBY')
def self.foo
^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~'RUBY')
def self.foo; end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def self.foo; end')
end
end
context 'with a non-empty class method definition' do
it 'allows multi line method' do
expect_no_offenses(<<~RUBY)
def self.foo
bar
end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def self.foo; bar; end')
end
it 'allows multi line method with comment' do
expect_no_offenses(<<~RUBY)
def self.foo
# bar
end
RUBY
end
end
context 'relation with Layout/LineLength' do
let(:other_cops) do
{
'Layout/LineLength' => {
'Enabled' => line_length_enabled,
'Max' => 20
}
}
end
let(:line_length_enabled) { true }
context 'when that cop is disabled' do
let(:line_length_enabled) { false }
it 'corrects to long lines' do
expect_offense(<<~RUBY)
def foo(abc: '10000', def: '20000', ghi: '30000')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_correction(<<~RUBY)
def foo(abc: '10000', def: '20000', ghi: '30000'); end
RUBY
end
end
context 'when the correction would exceed the configured maximum' do
it 'reports an offense but does not correct' do
expect_offense(<<~RUBY)
def foo(abc: '10000', def: '20000', ghi: '30000')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Put empty method definitions on a single line.
end
RUBY
expect_no_corrections
end
end
end
end
context 'when configured with expanded style' do
let(:cop_config) { { 'EnforcedStyle' => 'expanded' } }
context 'with an empty instance method definition' do
it 'allows multi line method' do
expect_no_offenses(<<~RUBY)
def foo
end
RUBY
end
it 'allows multi line method with blank line' do
expect_no_offenses(<<~RUBY)
def foo
end
RUBY
end
it 'registers an offense for single line method' do
expect_offense(<<~'RUBY')
def foo; end
^^^^^^^^^^^^ Put the `end` of empty method definitions on the next line.
RUBY
expect_correction(<<~'RUBY')
def foo
end
RUBY
end
end
context 'with a non-empty instance method definition' do
it 'allows multi line method' do
expect_no_offenses(<<~RUBY)
def foo
bar
end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def foo; bar; end')
end
it 'allows multi line method with a comment' do
expect_no_offenses(<<~RUBY)
def foo
# bar
end
RUBY
end
end
context 'with an empty class method definition' do
it 'allows empty multi line method' do
expect_no_offenses(<<~RUBY)
def self.foo
end
RUBY
end
it 'allows multi line method with a blank line' do
expect_no_offenses(<<~RUBY)
def self.foo
end
RUBY
end
it 'registers an offense for single line method' do
expect_offense(<<~'RUBY')
def self.foo; end
^^^^^^^^^^^^^^^^^ Put the `end` of empty method definitions on the next line.
RUBY
expect_correction(<<~'RUBY')
def self.foo
end
RUBY
end
end
context 'with a non-empty class method definition' do
it 'allows multi line method' do
expect_no_offenses(<<~RUBY)
def self.foo
bar
end
RUBY
end
it 'allows single line method' do
expect_no_offenses('def self.foo; bar; end')
end
it 'allows multi line method with comment' do
expect_no_offenses(<<~RUBY)
def self.foo
# bar
end
RUBY
end
end
context 'when method is nested in class scope' do
it 'registers an offense for single line method' do
expect_offense(<<~RUBY)
class Foo
def bar; end
^^^^^^^^^^^^ Put the `end` of empty method definitions on the next line.
end
RUBY
expect_correction(<<~RUBY)
class Foo
def bar
end
end
RUBY
end
end
context 'relation with Layout/LineLength' do
let(:other_cops) do
{
'Layout/LineLength' => {
'Enabled' => true,
'Max' => 20
}
}
end
it 'still corrects even if the method is longer than the configured Max' do
expect_offense(<<~RUBY)
def foo(abc: '10000', def: '20000', ghi: '30000'); end
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Put the `end` of empty method definitions on the next line.
RUBY
expect_correction(<<~RUBY)
def foo(abc: '10000', def: '20000', ghi: '30000')
end
RUBY
end
end
end
end