forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 0
/
literal_assignment_in_condition_spec.rb
246 lines (212 loc) · 7.64 KB
/
literal_assignment_in_condition_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::LiteralAssignmentInCondition, :config do
it 'registers an offense when assigning integer literal to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning string literal to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = 'foo'
^^^^^^^ Don't use literal assignment `= 'foo'` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'does not register an offense when assigning interpolated string literal to local variable in `if` condition' do
expect_no_offenses(<<~'RUBY')
if test = "#{foo}"
end
RUBY
end
it 'does not register an offense when assigning xstring literal to local variable in `if` condition' do
expect_no_offenses(<<~RUBY)
if test = `echo 'hi'`
end
RUBY
end
it 'registers an offense when assigning empty array literal to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = []
^^^^ Don't use literal assignment `= []` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning array literal with only literal elements to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = [1, 2, 3]
^^^^^^^^^^^ Don't use literal assignment `= [1, 2, 3]` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'does not register an offense when assigning array literal with non-literal elements to local variable in `if` condition' do
expect_no_offenses(<<~RUBY)
if test = [42, x, y]
end
RUBY
end
it 'registers an offense when assigning empty hash literal to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = {}
^^^^ Don't use literal assignment `= {}` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning hash literal with only literal elements to local variable in `if` condition' do
expect_offense(<<~RUBY)
if test = {x: :y}
^^^^^^^^^ Don't use literal assignment `= {x: :y}` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'does not register an offense when assigning hash literal with non-literal key to local variable in `if` condition' do
expect_no_offenses(<<~RUBY)
if test = {x => :y}
end
RUBY
end
it 'does not register an offense when assigning hash literal with non-literal value to local variable in `if` condition' do
expect_no_offenses(<<~RUBY)
if test = {x: y}
end
RUBY
end
it 'does not register an offense when assigning non-literal to local variable in `if` condition' do
expect_no_offenses(<<~RUBY)
if test = do_something
end
RUBY
end
it 'registers an offense when assigning literal to local variable in `while` condition' do
expect_offense(<<~RUBY)
while test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning literal to local variable in `until` condition' do
expect_offense(<<~RUBY)
until test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning literal to instance variable in condition' do
expect_offense(<<~RUBY)
if @test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning literal to class variable in condition' do
expect_offense(<<~RUBY)
if @@test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning literal to global variable in condition' do
expect_offense(<<~RUBY)
if $test = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'registers an offense when assigning literal to constant in condition' do
expect_offense(<<~RUBY)
if TEST = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'does not register an offense when assigning literal to collection element in condition' do
expect_no_offenses(<<~RUBY)
if collection[index] = 42
end
RUBY
end
it 'does not register an offense when `==` in condition' do
expect_no_offenses(<<~RUBY)
if test == 10
end
RUBY
end
it 'registers an offense when assigning after `== `in condition' do
expect_offense(<<~RUBY)
if test == 10 || foo = 1
^^^ Don't use literal assignment `= 1` in conditional, should be `==` or non-literal operand.
end
RUBY
end
it 'does not register an offense when `=` in a block that is called in a condition' do
expect_no_offenses('return 1 if any_errors? { o = inspect(file) }')
end
it 'does not register an offense when `=` in a block followed by method call' do
expect_no_offenses('return 1 if any_errors? { o = file }.present?')
end
it 'does not register an offense when assignment in a block after `||`' do
expect_no_offenses(<<~RUBY)
if x?(bar) || y? { z = baz }
foo
end
RUBY
end
it 'registers an offense when `=` in condition inside a block' do
expect_offense(<<~RUBY)
foo { x if y = 42 }
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
RUBY
end
it 'does not register an offense when `=` in condition inside a block' do
expect_no_offenses(<<~RUBY)
foo { x if y = z }
RUBY
end
it 'does not register an offense when `||=` in condition' do
expect_no_offenses('raise StandardError unless foo ||= bar')
end
it 'registers an offense when literal assignment after `||=` in condition' do
expect_offense(<<~RUBY)
raise StandardError unless (foo ||= bar) || a = 42
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
RUBY
end
it 'does not register an offense when assigning non-literal after `||=` in condition' do
expect_no_offenses(<<~RUBY)
raise StandardError unless (foo ||= bar) || a = b
RUBY
end
it 'does not register an offense when assignment method in condition' do
expect_no_offenses(<<~RUBY)
if test.method = 42
end
RUBY
end
it 'does not blow up when empty `if` condition' do
expect_no_offenses(<<~RUBY)
if ()
end
RUBY
end
it 'does not blow up when empty `unless` condition' do
expect_no_offenses(<<~RUBY)
unless ()
end
RUBY
end
it 'does not register an offense when using parallel assignment with splat operator in the block of guard condition' do
expect_no_offenses(<<~RUBY)
return if do_something do |z|
x, y = *z
end
RUBY
end
it 'registers when `=` in condition surrounded with braces' do
expect_offense(<<~RUBY)
if (test = 42)
^^^^ Don't use literal assignment `= 42` in conditional, should be `==` or non-literal operand.
end
RUBY
end
end