forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 0
/
quoted_symbols_spec.rb
269 lines (221 loc) · 6.44 KB
/
quoted_symbols_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::QuotedSymbols, :config do
shared_examples_for 'enforce single quotes' do
it 'accepts unquoted symbols' do
expect_no_offenses(<<~RUBY)
:a
RUBY
end
it 'accepts single quotes' do
expect_no_offenses(<<~RUBY)
:'a'
RUBY
end
it 'accepts double quotes with interpolation' do
expect_no_offenses(<<~'RUBY')
:"#{a}"
RUBY
end
it 'accepts double quotes when interpolating an instance variable' do
expect_no_offenses(<<~'RUBY')
:"#@test"
RUBY
end
it 'accepts double quotes when interpolating a global variable' do
expect_no_offenses(<<~'RUBY')
:"#$test"
RUBY
end
it 'accepts double quotes when interpolating a class variable' do
expect_no_offenses(<<~'RUBY')
:"#@@test"
RUBY
end
it 'accepts double quotes with escape sequences' do
expect_no_offenses(<<~RUBY)
:"a\nb"
RUBY
end
it 'accepts single quotes with double quotes' do
expect_no_offenses(<<~RUBY)
:'"'
RUBY
end
it 'accepts double quotes with single quotes' do
expect_no_offenses(<<~RUBY)
:"'"
RUBY
end
it 'accepts single quotes with line breaks' do
expect_no_offenses(<<~RUBY)
:'a
bc'
RUBY
end
it 'accepts double quotes with line breaks' do
expect_no_offenses(<<~RUBY)
:"a
bc"
RUBY
end
it 'accepts double quotes when control characters are used' do
expect_no_offenses(<<~'RUBY')
:"\e"
RUBY
end
it 'accepts double quotes when unicode control sequence is used' do
expect_no_offenses(<<~'RUBY')
:"Espa\u00f1a"
RUBY
end
it 'accepts double quotes with some other special symbols' do
# "Substitutions in double-quoted symbols"
# http://www.ruby-doc.org/docs/ProgrammingRuby/html/language.html
expect_no_offenses(<<~'RUBY')
g = :"\x3D"
copyright = :"\u00A9"
RUBY
end
it 'registers an offense and corrects for double quotes without interpolation' do
expect_offense(<<~RUBY)
:"a"
^^^^ Prefer single-quoted symbols when you don't need string interpolation or special symbols.
RUBY
expect_correction(<<~RUBY)
:'a'
RUBY
end
it 'registers an offense and corrects for double quotes in hash keys' do
expect_offense(<<~RUBY)
{ "a": value }
^^^ Prefer single-quoted symbols when you don't need string interpolation or special symbols.
RUBY
expect_correction(<<~RUBY)
{ 'a': value }
RUBY
end
context 'hash with hashrocket style' do
it 'accepts properly quoted symbols' do
expect_no_offenses(<<~RUBY)
{ :'a' => value }
RUBY
end
it 'corrects wrong quotes' do
expect_offense(<<~RUBY)
{ :"a" => value }
^^^^ Prefer single-quoted symbols when you don't need string interpolation or special symbols.
RUBY
expect_correction(<<~RUBY)
{ :'a' => value }
RUBY
end
end
end
shared_examples_for 'enforce double quotes' do
it 'accepts unquoted symbols' do
expect_no_offenses(<<~RUBY)
:a
RUBY
end
it 'accepts double quotes' do
expect_no_offenses(<<~RUBY)
:"a"
RUBY
end
it 'accepts double quotes with interpolation' do
expect_no_offenses(<<~'RUBY')
:"#{a}"
RUBY
end
it 'accepts double quotes when interpolating an instance variable' do
expect_no_offenses(<<~'RUBY')
:"#@test"
RUBY
end
it 'accepts double quotes when interpolating a global variable' do
expect_no_offenses(<<~'RUBY')
:"#$test"
RUBY
end
it 'accepts double quotes when interpolating a class variable' do
expect_no_offenses(<<~'RUBY')
:"#@@test"
RUBY
end
it 'accepts double quotes with escape sequences' do
expect_no_offenses(<<~RUBY)
:"a\nb"
RUBY
end
it 'accepts single quotes with double quotes' do
expect_no_offenses(<<~RUBY)
:'"'
RUBY
end
it 'accepts double quotes with single quotes' do
expect_no_offenses(<<~RUBY)
:"'"
RUBY
end
it 'accepts single quotes with line breaks' do
expect_no_offenses(<<~RUBY)
:'a
bc'
RUBY
end
it 'accepts double quotes with line breaks' do
expect_no_offenses(<<~RUBY)
:'a
bc'
RUBY
end
it 'registers an offense for single quotes' do
expect_offense(<<~RUBY)
:'a'
^^^^ Prefer double-quoted symbols unless you need single quotes to avoid extra backslashes for escaping.
RUBY
expect_correction(<<~RUBY)
:"a"
RUBY
end
context 'hash with hashrocket style' do
it 'accepts properly quoted symbols' do
expect_no_offenses(<<~RUBY)
{ :"a" => value }
RUBY
end
it 'corrects wrong quotes' do
expect_offense(<<~RUBY)
{ :'a' => value }
^^^^ Prefer double-quoted symbols unless you need single quotes to avoid extra backslashes for escaping.
RUBY
expect_correction(<<~RUBY)
{ :"a" => value }
RUBY
end
end
end
context 'configured with `same_as_string_literals`' do
let(:cop_config) { { 'EnforcedStyle' => 'same_as_string_literals' } }
context 'when Style/StringLiterals is configured with single_quotes' do
let(:other_cops) { { 'Style/StringLiterals' => { 'EnforcedStyle' => 'single_quotes' } } }
it_behaves_like 'enforce single quotes'
end
context 'when Style/StringLiterals is configured with double_quotes' do
let(:other_cops) { { 'Style/StringLiterals' => { 'EnforcedStyle' => 'double_quotes' } } }
it_behaves_like 'enforce double quotes'
end
context 'when Style/StringLiterals is disabled' do
let(:other_cops) { { 'Style/StringLiterals' => { 'Enabled' => false } } }
it_behaves_like 'enforce single quotes'
end
end
context 'configured with `single_quotes`' do
let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
it_behaves_like 'enforce single quotes'
end
context 'configured with `double_quotes`' do
let(:cop_config) { { 'EnforcedStyle' => 'double_quotes' } }
it_behaves_like 'enforce double quotes'
end
end