forked from rubocop/rubocop
/
identical_conditional_branches_spec.rb
397 lines (368 loc) · 8.05 KB
/
identical_conditional_branches_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::IdenticalConditionalBranches, :config do
context 'on if..else with identical bodies' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
if something
do_x
^^^^ Move `do_x` out of the conditional.
else
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
if something
else
end
do_x
RUBY
end
end
context 'on if..else with identical trailing lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
if something
method_call_here(1, 2, 3)
do_x
^^^^ Move `do_x` out of the conditional.
else
1 + 2 + 3
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
if something
method_call_here(1, 2, 3)
else
1 + 2 + 3
end
do_x
RUBY
end
end
context 'on if..else with identical leading lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
if something
do_x
^^^^ Move `do_x` out of the conditional.
method_call_here(1, 2, 3)
else
do_x
^^^^ Move `do_x` out of the conditional.
1 + 2 + 3
end
RUBY
expect_correction(<<~RUBY)
do_x
if something
method_call_here(1, 2, 3)
else
1 + 2 + 3
end
RUBY
end
end
context 'on if..elsif with no else' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
if something
do_x
elsif something_else
do_x
end
RUBY
end
end
context 'on if..else with slightly different trailing lines' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
if something
do_x(1)
else
do_x(2)
end
RUBY
end
end
context 'on case with identical bodies' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
case something
when :a
do_x
^^^^ Move `do_x` out of the conditional.
when :b
do_x
^^^^ Move `do_x` out of the conditional.
else
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
case something
when :a
when :b
else
end
do_x
RUBY
end
end
# Regression: https://github.com/rubocop/rubocop/issues/3868
context 'when one of the case branches is empty' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
case value
when cond1
else
if cond2
else
end
end
RUBY
end
end
context 'on case with identical trailing lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
case something
when :a
x1
do_x
^^^^ Move `do_x` out of the conditional.
when :b
x2
do_x
^^^^ Move `do_x` out of the conditional.
else
x3
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
case something
when :a
x1
when :b
x2
else
x3
end
do_x
RUBY
end
end
context 'on case with identical leading lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
case something
when :a
do_x
^^^^ Move `do_x` out of the conditional.
x1
when :b
do_x
^^^^ Move `do_x` out of the conditional.
x2
else
do_x
^^^^ Move `do_x` out of the conditional.
x3
end
RUBY
expect_correction(<<~RUBY)
do_x
case something
when :a
x1
when :b
x2
else
x3
end
RUBY
end
end
context 'on case without else' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
case something
when :a
do_x
when :b
do_x
end
RUBY
end
end
context 'on case with empty when' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
case something
when :a
do_x
do_y
when :b
else
do_x
do_z
end
RUBY
end
end
context 'when using pattern matching', :ruby27 do
context 'on case-match with identical bodies' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
case something
in :a
do_x
^^^^ Move `do_x` out of the conditional.
in :b
do_x
^^^^ Move `do_x` out of the conditional.
else
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
case something
in :a
in :b
else
end
do_x
RUBY
end
end
context 'when one of the case-match branches is empty' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
case value
in cond1
else
if cond2
else
end
end
RUBY
end
end
context 'on case-match with identical trailing lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
case something
in :a
x1
do_x
^^^^ Move `do_x` out of the conditional.
in :b
x2
do_x
^^^^ Move `do_x` out of the conditional.
else
x3
do_x
^^^^ Move `do_x` out of the conditional.
end
RUBY
expect_correction(<<~RUBY)
case something
in :a
x1
in :b
x2
else
x3
end
do_x
RUBY
end
end
context 'on case-match with identical leading lines' do
it 'registers and corrects an offense' do
expect_offense(<<~RUBY)
case something
in :a
do_x
^^^^ Move `do_x` out of the conditional.
x1
in :b
do_x
^^^^ Move `do_x` out of the conditional.
x2
else
do_x
^^^^ Move `do_x` out of the conditional.
x3
end
RUBY
expect_correction(<<~RUBY)
do_x
case something
in :a
x1
in :b
x2
else
x3
end
RUBY
end
end
context 'on case-match without else' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
case something
in :a
do_x
in :b
do_x
end
RUBY
end
end
context 'on case-match with empty when' do
it "doesn't register an offense" do
expect_no_offenses(<<~RUBY)
case something
in :a
do_x
do_y
in :b
else
do_x
do_z
end
RUBY
end
end
end
context 'with empty brace' do
it 'does not raise any error' do
expect_no_offenses(<<~RUBY)
if condition
()
else
()
end
RUBY
end
end
context 'with a ternary' do
it 'registers an offense' do
expect_offense(<<~RUBY)
x ? y : y
^ Move `y` out of the conditional.
^ Move `y` out of the conditional.
RUBY
expect_no_corrections
end
end
end