forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 0
/
redundant_cop_enable_directive_spec.rb
216 lines (186 loc) · 6.87 KB
/
redundant_cop_enable_directive_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::RedundantCopEnableDirective do
subject(:cop) { described_class.new }
it 'registers offense and corrects unnecessary enable' do
expect_offense(<<~RUBY)
foo
# rubocop:enable Layout/LineLength
^^^^^^^^^^^^^^^^^ Unnecessary enabling of Layout/LineLength.
RUBY
expect_correction(<<~RUBY)
foo
RUBY
end
it 'registers an offense and corrects when the first cop is ' \
'unnecessarily enabled' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Metrics/AbcSize, Layout/LineLength
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Layout/LineLength
RUBY
end
it 'registers multiple offenses and corrects the same comment' do
expect_offense(<<~RUBY)
foo
# rubocop:enable Metrics/ModuleLength, Metrics/AbcSize
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
^^^^^^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/ModuleLength.
bar
RUBY
expect_correction(<<~RUBY)
foo
bar
RUBY
end
it 'registers correct offense when combined with necessary enable' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength
fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo = barrrrrrrrrrrrrrrrrrrrrrrrrr
# rubocop:enable Metrics/AbcSize, Layout/LineLength
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
bar
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength
fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo = barrrrrrrrrrrrrrrrrrrrrrrrrr
# rubocop:enable Layout/LineLength
bar
RUBY
end
it 'registers offense and corrects redundant enabling of same cop' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength
fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo = barrrrrrrrrrrrrrrrrrrrrrrrrr
# rubocop:enable Layout/LineLength
bar
# rubocop:enable Layout/LineLength
^^^^^^^^^^^^^^^^^ Unnecessary enabling of Layout/LineLength.
bar
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength
fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo = barrrrrrrrrrrrrrrrrrrrrrrrrr
# rubocop:enable Layout/LineLength
bar
bar
RUBY
end
context 'all switch' do
it 'registers offense and corrects unnecessary enable all' do
expect_offense(<<~RUBY)
foo
# rubocop:enable all
^^^ Unnecessary enabling of all cops.
RUBY
expect_correction(<<~RUBY)
foo
RUBY
end
context 'when at least one cop was disabled' do
it 'does not register offense' do
expect_no_offenses(<<~RUBY)
# rubocop:disable Layout/LineLength
foooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo
# rubocop:enable all
RUBY
end
end
end
context 'when last cop is unnecessarily enabled' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Layout/LineLength, Metrics/AbcSize
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Layout/LineLength
RUBY
end
it 'registers an offense and corrects when there is no space ' \
'between the cops and the comma' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Layout/LineLength,Metrics/AbcSize
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength
foo
# rubocop:enable Layout/LineLength
RUBY
end
end
context 'when middle cop is unnecessarily enabled' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength, Lint/Debugger
foo
# rubocop:enable Layout/LineLength, Metrics/AbcSize, Lint/Debugger
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength, Lint/Debugger
foo
# rubocop:enable Layout/LineLength, Lint/Debugger
RUBY
end
it 'registers an offense and corrects when there is extra white space' do
expect_offense(<<~RUBY)
# rubocop:disable Layout/LineLength, Lint/Debugger
foo
# rubocop:enable Layout/LineLength, Metrics/AbcSize, Lint/Debugger
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
# rubocop:disable Layout/LineLength, Lint/Debugger
foo
# rubocop:enable Layout/LineLength, Lint/Debugger
RUBY
end
end
context 'when all cops are unnecessarily enabled' do
context 'on the same line' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
foo
# rubocop:enable Layout/LineLength, Metrics/AbcSize, Lint/Debugger
^^^^^^^^^^^^^ Unnecessary enabling of Lint/Debugger.
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
^^^^^^^^^^^^^^^^^ Unnecessary enabling of Layout/LineLength.
RUBY
expect_correction(<<~RUBY)
foo
RUBY
end
end
context 'on separate lines' do
it 'registers an offense and corrects when there is extra white space' do
expect_offense(<<~RUBY)
foo
# rubocop:enable Metrics/ModuleSize
^^^^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/ModuleSize.
# rubocop:enable Layout/LineLength, Metrics/ClassSize
^^^^^^^^^^^^^^^^^ Unnecessary enabling of Layout/LineLength.
^^^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/ClassSize.
# rubocop:enable Metrics/AbcSize, Lint/Debugger
^^^^^^^^^^^^^ Unnecessary enabling of Lint/Debugger.
^^^^^^^^^^^^^^^ Unnecessary enabling of Metrics/AbcSize.
RUBY
expect_correction(<<~RUBY)
foo
RUBY
end
end
end
end