forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 0
/
redundant_argument_spec.rb
129 lines (110 loc) · 3.54 KB
/
redundant_argument_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RedundantArgument, :config do
let(:cop_config) do
{ 'Methods' => { 'join' => '', 'split' => ' ', 'chomp' => "\n", 'chomp!' => "\n" } }
end
it 'registers an offense and corrects when method called on variable' do
expect_offense(<<~'RUBY')
foo.join('')
^^^^ Argument '' is redundant because it is implied by default.
foo.split(' ')
^^^^^ Argument ' ' is redundant because it is implied by default.
foo.chomp("\n")
^^^^^^ Argument "\n" is redundant because it is implied by default.
foo.chomp!("\n")
^^^^^^ Argument "\n" is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
foo.join
foo.split
foo.chomp
foo.chomp!
RUBY
end
it 'registers an offense and corrects when method called without parenthesis on variable' do
expect_offense(<<~RUBY)
foo.join ''
^^^ Argument '' is redundant because it is implied by default.
foo.split ' '
^^^^ Argument ' ' is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
foo.join
foo.split
RUBY
end
it 'registers an offense and corrects when method called on literals' do
expect_offense(<<~RUBY)
[1, 2, 3].join('')
^^^^ Argument '' is redundant because it is implied by default.
"first second".split(' ')
^^^^^ Argument ' ' is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
[1, 2, 3].join
"first second".split
RUBY
end
it 'registers an offense and corrects when method called without parenthesis on literals' do
expect_offense(<<~RUBY)
[1, 2, 3].join ''
^^^ Argument '' is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
[1, 2, 3].join
RUBY
end
it 'works with double-quoted strings when configuration is single-quotes' do
expect_offense(<<~RUBY)
foo.join("")
^^^^ Argument "" is redundant because it is implied by default.
"first second".split(" ")
^^^^^ Argument " " is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
foo.join
"first second".split
RUBY
end
it 'does not register an offense when method called with no arguments' do
expect_no_offenses(<<~RUBY)
foo.join
"first second".split
RUBY
end
it 'does not register an offense when method called with more than one arguments' do
expect_no_offenses(<<~RUBY)
foo.join('', 2)
[1, 2, 3].split(" ", true, {})
RUBY
end
it 'does not register an offense when method called with different argument' do
expect_no_offenses(<<~RUBY)
foo.join(',')
foo.split(',')
RUBY
end
it 'does not register an offense when method called with no receiver' do
expect_no_offenses(<<~RUBY)
join('')
split(' ')
RUBY
end
context 'non-builtin method' do
let(:cop_config) { { 'Methods' => { 'foo' => 2 } } }
it 'registers an offense and corrects with configured argument' do
expect_offense(<<~RUBY)
A.foo(2)
^^^ Argument 2 is redundant because it is implied by default.
RUBY
expect_correction(<<~RUBY)
A.foo
RUBY
end
it 'does not register an offense with other argument' do
expect_no_offenses(<<~RUBY)
A.foo(5)
RUBY
end
end
end