Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep gdu open when spawning shell #90

Closed
Tungstwenty opened this issue Aug 30, 2021 · 10 comments
Closed

Keep gdu open when spawning shell #90

Tungstwenty opened this issue Aug 30, 2021 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@Tungstwenty
Copy link

I use the new 'b' shortcut to quickly open a shell on a folder that is of interest to me and it's very useful.
One thing I think could be improved is if the shell would be opened without killing gdu, so that after exiting the shell I would still have all the data loaded, the same folder selected, etc. in order to investigate the next problematic folder and so on.
Much like the way you can user "! ..." in vi to spawn a shell and resume where you were once the shell ends.

@dundee
Copy link
Owner

dundee commented Aug 31, 2021

Unfortunately I wasn't able to implement this with the current terminal library (https://github.com/rivo/tview). There is possibility to pause the interface of the application, but it was not working for me properly, the user interface froze after returning back from shell.

@Tungstwenty
Copy link
Author

Did you have a look at this issue on their tracker? rivo/tview#244
There's some reproducer code there and indication that the issue is now fixed (if it's the same, that is)

@dundee
Copy link
Owner

dundee commented Sep 1, 2021

Thanks for link, I will try to investigate more.

@dundee dundee closed this as completed in 3286bfc Sep 5, 2021
@dundee dundee self-assigned this Sep 5, 2021
@dundee dundee added the bug Something isn't working label Sep 5, 2021
@rashil2000
Copy link
Contributor

...but it was not working for me properly, the user interface froze after returning back from shell.

Hi @dundee

I ran the latest build v5.7.0 (on Windows) but I'm still facing this, the UI hangs after exiting the shell.

@dundee
Copy link
Owner

dundee commented Sep 8, 2021

...but it was not working for me properly, the user interface froze after returning back from shell.

Hi @dundee

I ran the latest build v5.7.0 (on Windows) but I'm still facing this, the UI hangs after exiting the shell.

Thanks, I will try to investigate it.

@rashil2000
Copy link
Contributor

Hi @dundee, any updates on this?

Still facing it on 5.9.0.

@dundee
Copy link
Owner

dundee commented Oct 25, 2021

Hi @dundee, any updates on this?

Still facing it on 5.9.0.

We will have to wait till rivo/tview#244 is fixed.

@rashil2000
Copy link
Contributor

Would it be a good idea to exit gdu on Windows (when the shell is exited, just like the initial behavior), till the upstream bug is fixed?

@dundee
Copy link
Owner

dundee commented Oct 25, 2021

Yes, that will be a good work-around. I have created issue for this - #101

@rashil2000
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants