Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dynamic project metadata #339

Open
nbraud opened this issue Nov 17, 2023 · 3 comments
Open

Handle dynamic project metadata #339

nbraud opened this issue Nov 17, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@nbraud
Copy link
Collaborator

nbraud commented Nov 17, 2023

bork build fails if pyproject.toml doesn't contain project.name.

While PEP 621 guarantees that name is (statically) defined if the project table exists, it also specifies

The lack of a [project] table implicitly means the build back-end will dynamically provide all fields.

In that case, bork should call {build-backend}.prepare_metadata_for_build_wheel
and extract the metadata from the .dist-info directory that was populated.

@nbraud nbraud added the enhancement New feature or request label Nov 17, 2023
@nbraud nbraud self-assigned this Nov 17, 2023
@duckinator
Copy link
Owner

duckinator commented Nov 19, 2023

Oh, this means we can probably remove all remaining explicit references to setup.cfg, nice!

@duckinator
Copy link
Owner

As @AstraLuma mentions in #349:

bork zipapps require that a project table appears in pyproject.toml. Poetry-based projects use tool.poetry instead.

So an example project using Poetry would provide a good testcase for this functionality.

@duckinator
Copy link
Owner

#352 appears to be a manifestation of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants