Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have GithubApi.last_release ignore prereleases #286

Open
duckinator opened this issue Nov 1, 2022 · 2 comments
Open

Have GithubApi.last_release ignore prereleases #286

duckinator opened this issue Nov 1, 2022 · 2 comments
Milestone
v7.1.0

Comments

@duckinator
Copy link
Owner

At the moment, if you (for example) release v6.0.0b1 then v6.0.0, you have to delete the v6.0.0b1 release first or v6.0.0 won't include all the relevant changes from the last stable version.

If GithubApi.last_release were to ignore prereleases (TODO: determine technical requirements for this), it would avoid this problem entirely. It might be worth renaming it to make it clear it doesn't include prereleases (maybe to last_stable_release?), but I'm not sure it matters as long as it's documented.
@duckinator duckinator added this to the v??? milestone Apr 27, 2023
@duckinator

This comment was marked as outdated.

Sign in to view
@duckinator duckinator closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
@duckinator duckinator reopened this Nov 8, 2023
@duckinator
Copy link
Owner Author

duckinator commented Nov 8, 2023 •
edited

The codebase filters out prereleases elsewhere -- namely bork.github.GithubRelease._get_release_info() -- so I think I'm going to consider this a bug, not a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.1.0
Development

No branches or pull requests
1 participant
@duckinator