Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error reporting #242

Open
nbraud opened this issue Jan 6, 2021 · 3 comments
Open

Improve the error reporting #242

nbraud opened this issue Jan 6, 2021 · 3 comments
Assignees

Comments

@nbraud
Copy link
Collaborator

nbraud commented Jan 6, 2021

Continuation of #240. Currently, the error and warning logs can get pushed off the screen by the backtrace.

@nbraud nbraud self-assigned this Jan 6, 2021
@nbraud
Copy link
Collaborator Author

nbraud commented Jan 6, 2021

@duckinator What would you think of logging the backtrace to a temporary file and giving a link to that (unless the user requests verbose errors via a CLI flag or an environment variable)

@duckinator
Copy link
Owner

@nbraud I'd be okay with that. Do you think we should tie it to --verbose, --debug, or something else?

(Sorry for the slow response, in the process of getting a new house.)

@nbraud
Copy link
Collaborator Author

nbraud commented Feb 1, 2021

@nbraud Do you think we should tie it to --verbose, --debug, or something else?

Yes, I think it would make sense not to display the backtrace (and only the exception itself) unless some flag is set, and unconditionally save it to a text file.

(Sorry for the slow response, in the process of getting a new house.)

I know, hon, and it's entirely fine. I've not been particularly responsive myself either in the last couple of months, and I'm not even moving ;3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants