Consistently use quote! when emitting 'source'
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a macro generates part of the derive input, the call-site hygiene may be different than the hygiene of a field. Therefore, we need to be sure to use the same hygiene information for any identifiers we generate, instead of relying on the hygiene from a particular span via `quote_spanned!`
Aaron1011
force-pushed
the
fix/source-span
branch
from
e7e7afd
to
0fa679b
Compare
dtolnay
reviewed
Feb 19, 2021
| let source_backtrace = if type_is_option(source_field.ty) { | ||
| quote_spanned! {source.span()=> | ||
| source.as_ref().and_then(|source| source.as_dyn_error().backtrace()) | ||
| #source_literal.as_ref().and_then(|source| #source_literal.as_dyn_error().backtrace()) |
There was a problem hiding this comment.
This looks wrong -- I am going to turn this back into |source| source.as_dyn_error().backtrace() in the merge.
There was a problem hiding this comment.
Good catch! Sorry about that.
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a macro generates part of the derive input, the call-site hygiene
may be different than the hygiene of a field. Therefore, we need to
be sure to use the same hygiene information for any identifiers we
generate, instead of relying on the hygiene from a particular span
via
quote_spanned!