Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Parse for ExprArray #991

Merged
merged 1 commit into from
Mar 28, 2021
Merged

impl Parse for ExprArray #991

merged 1 commit into from
Mar 28, 2021

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Mar 28, 2021

ExprArray can be parsed directly rather than going through impl_by_parsing_expr. This makes the following type of thing possible:

let x: ExprArray = input.parse()?;
let _: Token![+] = input.parse()?;
let y: ExprArray = input.parse()?;

which previously would have failed due to the + being eagerly consumed as part of x, making it into ExprBinary, and thereby failing to parse x as ExprArray.

@dtolnay dtolnay merged commit 4586f5c into master Mar 28, 2021
@dtolnay dtolnay deleted the exprparse branch March 28, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant