Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention 5036fd9c6e9b89809f93a6ffa17ac6663652baed in release notes for 2.0.9 #1424

Closed
asomers opened this issue Mar 25, 2023 · 1 comment
Closed

Comments

@asomers
Copy link

asomers commented Mar 25, 2023

Could you please update the release notes to describe change 5036fd9 ? It caused mockall to fail in some cases, and I was surprised to see a breaking change missing from the release notes.

The offending syntax is

/// method doc comment
fn boo(&self);

when parsing this as an ImplItem, syn 2.0.8 would parse it as an ImplItem::Fn, but syn 2.0.9 parses it as ImplItem::Verbatim.

@dtolnay
Copy link
Owner

dtolnay commented May 11, 2024

Done — sorry about the breakage.

@dtolnay dtolnay closed this as completed May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants