Restrict PartialOrd comparison to only tokens in the same buffer #1237
Conversation
error: casting `usize` to `isize` may wrap around the value
--> src/buffer.rs:56:46
|
56 | entries.push(Entry::End(-(group_end_index as isize)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
= note: `-D clippy::cast-possible-wrap` implied by `-D clippy::pedantic`
error: casting `usize` to `isize` may wrap around the value
--> src/buffer.rs:82:34
|
82 | entries.push(Entry::End(-(entries.len() as isize)));
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
There was a problem hiding this comment.
That looks really good to me! It's definitely nice to have the cursors for distinct buffers unordered rather than arbitrary-but-consistent order.
It's nice it also gives a purpose to the End entries rather than them solely existing to make implementation easier.
(And as a tertiary nicety, it doesn't necessarily preclude a rewrite of Cursor that uses slices and less unsafe, as such could still do the offset for comparison, just not access outside the cursor range.)
TLDR: r+
(Apparently, "Can not approve pull request without explicit repository access" — did GH decide to prevent drive-by PR approvals? Or is that an old setting I don't know about? Irrelevant, I guess; though it is nice to be able to give a structured ±1 without merge capabilities, it's definitely abusable.)
How does this look @CAD97? I was hesitant about directly exposing a pointer comparison across unrelated allocations.