Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appending inner attrs onto an existing attributes vector, instead of into a separate vector which the caller is responsible for combining together, is more amenable for an upcoming refactor -- it's more convenient to pass
&mut attrs
as an argument to various helpers, rather than trying to pass back inner attrs as a tuple element in return position, which is always clumsy.The rustc parser follows the same strategy, such as in https://github.com/rust-lang/rust/blob/b849326744a8eec939e592f0ab13bff85cc865d3/compiler/rustc_parse/src/parser/item.rs#L33-L48.