Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any impl Spanned for quote_spanned! #231

Open
Kyuuhachi opened this issue Oct 12, 2022 · 0 comments
Open

Allow any impl Spanned for quote_spanned! #231

Kyuuhachi opened this issue Oct 12, 2022 · 0 comments

Comments

@Kyuuhachi
Copy link

In almost all cases I find myself using the span of an existing AST node, so needing to write .span()=> everywhere is a lot of visual noise. And since Span is impl Spanned, I believe this would be backward compatible (though there could very well be some sort of special case I have not thought of). Would this be a reasonable change, or is there some reason it is not so?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kyuuhachi