Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more context when raw ident fails to parse #173

Closed
wants to merge 1 commit into from
Closed

Provide more context when raw ident fails to parse #173

wants to merge 1 commit into from

Conversation

jonas-schievink
Copy link

We're hitting this assertion in rust-analyzer, and this helps debugging.

@dtolnay dtolnay mentioned this pull request Dec 20, 2020
Merged
@dtolnay
Copy link
Owner

dtolnay commented Dec 20, 2020

It must be hitting one of the disallowed cases here:

https://github.com/rust-lang/rust/blob/b0e5c7d1fee37f1890455b977495bfe262716701/compiler/rustc_span/src/symbol.rs#L1636-L1638

  • r#_
  • r#super
  • r#self
  • r#Self
  • r#crate

@dtolnay dtolnay closed this in #175 Dec 20, 2020
dtolnay
dtolnay reviewed Dec 20, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I landed #175 instead which shows the raw identifier itself in the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonas-schievink @dtolnay