Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trycatch to call Fail using std::string #1114

Merged
merged 1 commit into from Oct 15, 2022
Merged

Allow trycatch to call Fail using std::string #1114

merged 1 commit into from Oct 15, 2022

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Oct 15, 2022

Before:

template <typename Try, typename Fail>
static void trycatch(Try &&func, Fail &&fail) noexcept try {
  func();
} catch (const whatever &ex) {
  std::ostringstream buf;
  ex.dump(buf);
  fail(buf.str().c_str());
}

After: just fail(buf.str()) without .c_str(), and performs better because we bypass a redundant strlen computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant