Fix incorrect string len if an exception's message is invalid UTF-8 #1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd create a PtrLen with the C++ string's length and the String::from_utf8_lossy string's data pointer. This is later turned back into a Rust string by:
cxx/src/result.rs
Lines 61 to 66 in a396524
Since in general the length of string produced by from_utf8_lossy can be longer than the original string, this could end up truncating characters off the end of the exception message when printed from Rust code.