Forward attributes on impl function parameters to variable declaration.
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azriel91
commented
Jan 6, 2023
| quote!( | ||
| #(#attrs)* | ||
| let #mutability #ident = #ident; | ||
| ) | ||
| } | ||
| } else { | ||
| let pat = &arg.pat; |
There was a problem hiding this comment.
I'm not sure how to hit this branch -- I tried using a DeconstructedStruct { value } but it didn't parse.
Presumably the same attribute forwarding needs to be done here as well
There was a problem hiding this comment.
Try #[cfg(any())] _: T or #[cfg(any())] (a, b): (T, T)
There was a problem hiding this comment.
cool thanks, managed to simplify the test case
azriel91
force-pushed
the
bugfix/226/forward-param-attributes
branch
from
40af21a
to
3cb7599
Compare
azriel91
force-pushed
the
bugfix/226/forward-param-attributes
branch
from
3cb7599
to
6cf682f
Compare
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 9, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [async-trait](https://github.com/dtolnay/async-trait) | dependencies | patch | `0.1.60` -> `0.1.61` | --- ### Release Notes <details> <summary>dtolnay/async-trait</summary> ### [`v0.1.61`](https://github.com/dtolnay/async-trait/releases/tag/0.1.61) [Compare Source](dtolnay/async-trait@0.1.60...0.1.61) - Fix async function signatures that involve #\[cfg(...)] attributes on parameters ([#​227](dtolnay/async-trait#227), thanks [@​azriel91](https://github.com/azriel91)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44NC4xIiwidXBkYXRlZEluVmVyIjoiMzQuOTMuMCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1707 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226.
It feels rare to have attributes on parameters, I can't imagine a concrete scenario where forwarding all attributes is undesirable.
We could filter the attributes that are forwarded to only the
#[cfg(..)]ones.