Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with tokio::select #162

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Compatibility with tokio::select #162

merged 3 commits into from
Apr 17, 2021
+36 −2

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Apr 17, 2021

Closes #161.

dtolnay added 3 commits April 17, 2021 15:54
@dtolnay
Add regression test for issue 161

Verified

This commit was signed with the committer’s verified signature. The key has expired.
wraithgar Gar
GPG key ID: A76652216DC51B79
Expired
Verified
Learn about vigilant mode
62f9924
@dtolnay
Treat select macro always as expression
54c5d9c
@dtolnay
Suppress clippy mut_mut pedantic lint in test suite
4db8933 
    error: generally you want to avoid `&mut &mut _` if possible
        --> tests/test.rs:1355:13
         |
    1355 | /             futures::select! {
    1356 | |                 _ = async {
    1357 | |                     println!("{}", self.0);
    1358 | |                 }.fuse() => {}
    1359 | |             }
         | |_____________^
         |
         = note: `-D clippy::mut-mut` implied by `-D clippy::pedantic`
         = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut
         = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
@dtolnay dtolnay merged commit 979ecce into master Apr 17, 2021
@dtolnay dtolnay deleted the select branch April 17, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not compatible with tokio::select!.
1 participant
@dtolnay