Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.44 starts triggering clippy::let-unit-value (off by default) warning #147

Closed
ndmitchell opened this issue Mar 5, 2021 · 0 comments · Fixed by #148
Closed

0.1.44 starts triggering clippy::let-unit-value (off by default) warning #147

ndmitchell opened this issue Mar 5, 2021 · 0 comments · Fixed by #148

Comments

@ndmitchell
Copy link

On upgrading from 0.1.42 to 0.1.44 we started getting a warning about clippy::let-unit-value, which we fixed by facebook/starlark-rust@63ac231. As a minimal reproducer:

struct MyType;

#[async_trait]
trait MyTrait {
    async fn foo();
}

#[async_trait]
impl MyTrait for MyType {
    async fn foo() {}
}

Note that we explicitly enable clippy::let-unit-value as it generally has been a useful hint.

It seems like anything that returns () as a result is likely to raise this issue. Perhaps the generated code could disable this lint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant