Handle parsing unseparated right angle brackets in generics #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these aren't being parsed successfully so this fails with:
---- test_path stdout ----
thread 'test_path' panicked at 'assertion failed: `(left == right)`
left: `"Condition failed: `E::U::<> > E::U::<u8>`"`,
right: `"Condition failed: `E::U::<> > E::U::<u8>` (U vs U)"`', tests/test_ensure.rs:332:5
thread 'test_path' panicked at 'assertion failed: `(left == right)`
left: `"Condition failed: `E::U::<u8> > E::U`"`,
right: `"Condition failed: `E::U::<u8> > E::U` (U vs U)"`', tests/test_ensure.rs:336:5
thread 'test_path' panicked at 'assertion failed: `(left == right)`
left: `"Condition failed: `E::U::<u8> > E::U`"`,
right: `"Condition failed: `E::U::<u8> > E::U` (U vs U)"`', tests/test_ensure.rs:340:5
error: adding items after statements is confusing, since items exist from the start of the scope
--> tests/test_ensure.rs:324:5
|
324 | / enum E<'a, T> {
325 | | #[allow(dead_code)]
326 | | T(&'a T),
327 | | U,
328 | | }
| |_____^
|
= note: `-D clippy::items-after-statements` implied by `-D clippy::pedantic`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustc parses
S::<>>vas an expression but it's harder for macro_rules, which have to know that a single incoming>>token serves as both the generic argument list terminator and the comparison operator.