Eliminate functionally duplicate vtable methods on rustc 1.51+ #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the raw pointer addr_of macro, it's possible for the vtable methods to avoid instantiating any
&
or&mut
and operate only in terms of pointers, allowingDeref
andDerefMut
to reuse a single piece of vtable logic, anddowncast_ref
anddowncast_mut
to reuse a single piece.Closes #62.
FYI @thomcc