Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Detection #385

Open
dshoreman opened this issue May 2, 2021 · 0 comments
Open

Step Detection #385

dshoreman opened this issue May 2, 2021 · 0 comments

Comments

@dshoreman
Copy link
Owner

We need a way of setting the actions that are expected to happen, so that when someone clicks the "Laravel" template, the progress modal will know, "okay this'll create an app, clone, composer install, enable the project and reload nginx" all before the process has started.

We could hack the data into templates.json, but then we'd have to keep it in sync with the backend. A better solution would be setting an actions var/method on the template classes, e.g. on a Laravel project...

class Laravel extends Php
{
    protected $actions = [
        new GitCloneAction(...), // app.clone
        new ComposerInstallAction(...) // app.install
        new NginxReloadAction(), // nginx.reload
    ];
}

The problem there is when the project is created, the backend has no idea what app or redirect will be attached. We'd need to return the actions list with the created app or redirect, but that still beats adding in sequence.

@dshoreman dshoreman created this issue from a note in Progress Component (To do) May 2, 2021
@dshoreman dshoreman added this to To do in Projects, Apps and Redirects via automation May 2, 2021
@dshoreman dshoreman added the enhancement New feature or request label May 2, 2021
dshoreman added a commit that referenced this issue Feb 17, 2023
This adds a new handler to the app and redirect saving events that
dispatches the 'pending' `ProjectProgress` events for all the relevant
steps so the progress modal can be populated once the project is saved.

Related: #385
dshoreman added a commit that referenced this issue Feb 17, 2023
This adds a new handler to the app and redirect saving events that
dispatches the 'pending' `ProjectProgress` events for all the relevant
steps so the progress modal can be populated once the project is saved.

Related: #385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant