Fix undefined in comment node type guards #1275
Merged
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
May 14, 2022
There was a problem hiding this comment.
LGTM. Thanks!
Yeah, repo is a bit of a mess and slow to work in atm because some things are in flux. I'll be rewriting it to be deno first in the future and compile for npm with dnt (https://github.com/denoland/dnt) in order to get rid of the deno directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this while working on a transform; the
ashides the fact that these can be undefined thanks tonode?. Maybe I should change the cast too.I'm not sure if I'm sending PRs correctly; there are a lot more changes in the repo when I build it, but they don't look related to any change I've made at all. Happy to let you make this change instead if I'm doing it wrong!