Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for canary versions from lerna #213

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

snowystinger
Copy link
Contributor

Support for canary versions from lerna #212

I need some help with the test, I don't know how to generate the snapshot

@snowystinger
Copy link
Contributor Author

hello?

@mikehardy
Copy link
Contributor

mikehardy commented Aug 31, 2020

I'm working on a github workflow that will auto-generate patch-package patch artifacts for PRs, and it would be nice to support appending the PR commit SHA to the patch files in order to have them named unambiguously (along with the PR as a pre-release tag, actually) so I'd love this to be integrated.

Instead of having this patch on PR1234, SHA a5a7d6a5:

patches/@react-native-firebase+database@6.7.2.patch

I could have:

patches/@react-native-firebase+database@6.7.2-PR1234+a5a7d6a5.patch

Then it would be very easy to see exactly where the patch came from

@ds300
Copy link
Owner

ds300 commented Feb 25, 2021

Thanks @snowystinger this change makes sense 👍 Sorry it took me so long to get around to it.

I'm going to merge and then fix up the tests directly on master 🙏🏼

@ds300 ds300 merged commit 6fa4e38 into ds300:master Feb 25, 2021
@ds300
Copy link
Owner

ds300 commented Feb 25, 2021

fixup commit incase anybody is interested: 2f1c855

@mikehardy
Copy link
Contributor

Hey @ds300 just wanted to say this package is a huge part of my react-native existence haha - thanks for the package in general, and the current time here merging this :-). Cheers

@snowystinger snowystinger deleted the support-lerna-canary branch February 25, 2021 17:29
@ds300
Copy link
Owner

ds300 commented Feb 27, 2021

This was just released in v6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants