Support metadata in I18n message backend #212
Merged
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates Dry::Schema::Messages::I18n#get to return a Hash including text and meta * Removes conditional from Dry::Schema::Messages::Abstract#lookup that disambiguated between a Strings and Hashes since both backends now returns Hashes * Supports Procs as I18n translations when metadata is present by using I18n.t rather than hash access when looking for text and meta values
|
@robhanlon22 thank you for addressing these issues, this is very helpful! I released 1.4.2 that includes your fixes. Here's the full changelog https://github.com/dry-rb/dry-schema/releases/tag/v1.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #208
resolves #210