refactor: harmonizes playing card typings #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tib-tib
reviewed
Dec 19, 2020
| @@ -1,16 +1,13 @@ | |||
| import { PlayingCard, PlayingCardName, PlayingCardSuit } from '@models/PlayingCard'; | |||
| import { allPlayingCardNames, allPlayingCardSuits, PlayingCard } from '@models/PlayingCard'; | |||
There was a problem hiding this comment.
No big deal and super minor, but I don't think we need the prefix all => playingCardNames would be enough in my opinion 😄
Also, I like it better in camel case, so maybe you could also change it for AllUnoColors & values.
I will approve anyway 😄
There was a problem hiding this comment.
e.g. PlayingCardNames ?
I since it's a constant, wouldn't that break the linter in this case?
Anyhow, I am ok for doing it. Perhaps the only point that is a bit slugish is that we will have a type PlayingCardName and an array constant as PlayingCardNames.
Shall we move forward?
tib-tib
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Typings from PlayingCard do not follow the same for UnoCard
Issue Number: Closes #122
What is the new behavior?
Typings normalized
Does this introduce a breaking change?
Other information
A picture tells a thousand words