Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonBlockingServletHolder still necessary? #3526

Closed
josephlbarnett opened this issue Oct 26, 2020 · 0 comments · Fixed by #3527
Closed

NonBlockingServletHolder still necessary? #3526

josephlbarnett opened this issue Oct 26, 2020 · 0 comments · Fixed by #3527
Assignees
@joschi
Labels
bug
Milestone
2.0.15

Comments

@josephlbarnett
Copy link
Contributor

Noticed that latest jetty release (9.4.33) was not binary compatible with latest dropwizard release (2.0.14) and filed an issue with jetty to let them know they've broken binary (but not source) compatibility. They are not going to revert back, but did question if NonBlockingServletHolder is still necessary, more details here:

jetty/jetty.project#5496 (comment)
joschi added a commit that referenced this issue Oct 26, 2020
@joschi
Remove obsolete NonblockingServletHolder
4491667 
Refs jetty/jetty.project#5496
Refs #3526
@joschi joschi mentioned this issue Oct 26, 2020
Merged
@joschi joschi linked a pull request Oct 26, 2020 that will close this issue
Remove obsolete NonblockingServletHolder #3527
Merged
joschi added a commit that referenced this issue Oct 28, 2020
@joschi
Remove obsolete NonblockingServletHolder (#3527)
eef4527 
Refs jetty/jetty.project#5496
Refs #3526
joschi added a commit that referenced this issue Oct 28, 2020
@joschi
Remove obsolete NonblockingServletHolder (#3527)
cfbf22f 
Refs jetty/jetty.project#5496
Refs #3526

(cherry picked from commit eef4527)
joschi added a commit that referenced this issue Oct 28, 2020
@joschi
Remove obsolete NonblockingServletHolder (#3527)
1688fb9 
Refs jetty/jetty.project#5496
Refs #3526

(cherry picked from commit eef4527)
@joschi joschi added this to the 2.0.15 milestone Oct 28, 2020
@joschi joschi added the bug label Oct 28, 2020
@joschi joschi self-assigned this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joschi joschi

Labels
bug
Projects
None yet
Milestone
2.0.15
Development

Successfully merging a pull request may close this issue.

Remove obsolete NonblockingServletHolder dropwizard/dropwizard
2 participants
@joschi @josephlbarnett