Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect location of screenshots for tests in flavored sources #30

Open
saket opened this issue Jan 20, 2023 · 4 comments
Open

Incorrect location of screenshots for tests in flavored sources #30

saket opened this issue Jan 20, 2023 · 4 comments

Comments

@saket
Copy link
Contributor

saket commented Jan 20, 2023

Dropshots stores screenshots in my androidTest directory even when my tests are present in androidTestDebug. Is this intentional?

@sebastienrouif
Copy link
Contributor

Hi Saket,
Interesting question, do you specify a specific path for your debug tests?
this is where the folder of the screenshots is defined: https://github.com/dropbox/dropshots/blob/main/dropshots-gradle-plugin/src/main/kotlin/com/dropbox/dropshots/DropshotsPlugin.kt#L47
Currently the folder doesn't seem to take into account the flavor and that is a problem if you are expecting different outputs from different flavors

@saket
Copy link
Contributor Author

saket commented Mar 16, 2023

do you specify a specific path for your debug tests?

do you mean in my build script?

@sebastienrouif
Copy link
Contributor

@rharter what was the reasoning to have the screenshots in the "screenshot" folder and not an asset folder inside a res/assets folder ?

@rharter
Copy link
Collaborator

rharter commented Apr 5, 2024

It's integrated into assets at built time, but it's also used as task input and output, so plays into Gradles up-to-date checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants