Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetch erros #1138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix fetch erros #1138

wants to merge 3 commits into from

Conversation

decovicdev
Copy link

@decovicdev decovicdev commented Apr 22, 2024 •
edited

Upgrade body access: Uses body.arrayBuffer() for response body, improving compatibility with future Node.js versions.
Load node-fetch: Only requires node-fetch when needed fixing node warnings.

fixes: #1137, #1135, #1130

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does npm test pass?
  • Does npm run build pass?
  • Does npm run lint pass?

@greg-db
Copy link
Contributor

greg-db commented Apr 23, 2024

Thanks for putting this together! I'll ask the team to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change deprecated .buffer() to .arrayBuffer()
2 participants
@decovicdev @greg-db