Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with the integration test #237

Open
tasomaniac opened this issue Dec 16, 2023 · 0 comments
Open

Problem with the integration test #237

tasomaniac opened this issue Dec 16, 2023 · 0 comments

Comments

@tasomaniac
Copy link

tasomaniac commented Dec 16, 2023

While browsing the project, I came across the following plugin functional tests. According to the line 110, the tasks are run with --dry-run. When they are run with dry-run, not matter what the plugin does, all the tasks will be "SKIPPED". And the test verifies only that they are "SKIPPED"

So my observation is that this test is evergreen.

https://github.com/dropbox/AffectedModuleDetector/blob/main/affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorIntegrationTest.kt#L110-L116

Screenshot 2023-12-16 at 18 56 42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant