Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: tmpdir is deprecated and we should use tmp_path instead #370

Open
pjbull opened this issue Oct 9, 2023 · 0 comments
Open

Tests: tmpdir is deprecated and we should use tmp_path instead #370

pjbull opened this issue Oct 9, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@pjbull
Copy link
Member

pjbull commented Oct 9, 2023

We use tmpdir throughout the tests, but it is deprecated:
https://docs.pytest.org/en/stable/how-to/tmp_path.html#the-tmpdir-and-tmpdir-factory-fixtures

We should remove replace tmpdir fixture with tmp_path throughout the test suite.

Originally posted by @jayqi in #361 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjbull