Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline from TestLogger time output #114

Merged
merged 1 commit into from Nov 16, 2022

Conversation

lazorchakp
Copy link
Contributor

I noticed a println! where I would have expected a print! in the TestLogger's write_time function. This was causing log statements to be formatted as:

15:28:59
[INFO] [my_project/src/foo.rs:441] Finished Task 1
15:28:59
[INFO] [my_project/src/foo.rs:444] Processing 0 items for Task 2
15:29:01
[INFO] [my_project/src/bar.rs:482] 1 Total Result

With this change, TestLogger output looks like:

15:28:59 [INFO] [my_project/src/foo.rs:441] Finished Task 1
15:28:59 [INFO] [my_project/src/foo.rs:444] Processing 0 items for Task 2
15:29:01 [INFO] [my_project/src/bar.rs:482] 1 Total Result

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.6%) to 53.947% when pulling 8481058 on lazorchakp:testlogger-remove-newline into c927c19 on Drakulix:master.

@Drakulix
Copy link
Owner

Good catch! Thanks :)

@Drakulix Drakulix merged commit 626467d into Drakulix:master Nov 16, 2022
@lazorchakp lazorchakp deleted the testlogger-remove-newline branch November 16, 2022 21:58
@Shatur
Copy link

Shatur commented Mar 2, 2023

@Drakulix could you please draft a new release with this bugfix?

@Drakulix
Copy link
Owner

Drakulix commented Mar 2, 2023

@Drakulix could you please draft a new release with this bugfix?

Published as 0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants